Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to trim pitch angle for level flight #6568

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented Feb 4, 2021

Closes #6561

The fw_level_pitch_trim can be used to trim pitch angle and is separated from the board orintation option.
To make it more user friendly, positive values means that nose should be raised UP for level flight.

The next step would be to add it to the Adjustments section and remove ROLL and PITCH board adjustments from Configurator GUI and Adjustments

@DzikuVx DzikuVx added the Release Notes Add this when a PR needs to be mentioned in the release notes label Feb 4, 2021
@DzikuVx DzikuVx added this to the 2.7 milestone Feb 4, 2021
@avsaase
Copy link
Member

avsaase commented Feb 4, 2021

This is much more intuitive. However I think the existing board alignments should stay in the configurator in case people want to mount their flight controller in other orientations than flat with the arrow pointing forward. But perhaps in the configurator it can be simplified similar to the magnetometer alignment, with the fine adjustments left to the CLI.

@DzikuVx
Copy link
Member Author

DzikuVx commented Feb 4, 2021

@avsaase board ROLL and PITCH board adjustments were used only for trimming. I do not know of any practical usage of those besides trimming. YAW stays as it's required for the correct board orientation (forward arrow).

For the super rare cases when user mounted the board on the strange angle and not flat, CLI adjustments stay

@DzikuVx DzikuVx merged commit c892036 into master Feb 5, 2021
@DzikuVx DzikuVx deleted the dzikuvx-static-level-pitch-trim branch February 5, 2021 08:54
@wx4cb
Copy link

wx4cb commented Feb 5, 2021

@avsaase board ROLL and PITCH board adjustments were used only for trimming. I do not know of any practical usage of those besides trimming. YAW stays as it's required for the correct board orientation (forward arrow).

For the super rare cases when user mounted the board on the strange angle and not flat, CLI adjustments stay

so instead of just changing the roll alignment in the configurator for a board that is mounted upside down ( I have one here in my glider where the only way is upside down in the belly hatch), i would have to do it in the cli?

@DzikuVx
Copy link
Member Author

DzikuVx commented Feb 5, 2021

@wx4cb Yes. On the other hand we might leave it as it is but with a red note not to use it to trim the airplane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate flight pitch angle and board orientation with setting for level flight pitch angle
3 participants